Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): only require github_info for lookml and not looker #6608

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix(ingest): only require github_info for lookml and not looker #6608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions metadata-ingestion/src/datahub/ingestion/source/looker/looker_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
import datahub.emitter.mce_builder as builder
from datahub.configuration import ConfigModel
from datahub.configuration.common import ConfigurationError
from datahub.configuration.github import GitHubInfo
from datahub.configuration.source_common import DatasetSourceConfigBase
from datahub.emitter.mcp import MetadataChangeProposalWrapper
from datahub.ingestion.api.report import Report
Expand Down Expand Up @@ -186,10 +185,6 @@ class LookerCommonConfig(DatasetSourceConfigBase):
platform_name: str = Field(
"looker", description="Default platform name. Don't change."
)
github_info: Optional[GitHubInfo] = Field(
None,
description="Reference to your github location. If present, supplies handy links to your lookml on the dataset entity page.",
)
extract_column_level_lineage: bool = Field(
True,
description="When enabled, extracts column-level lineage from Views and Explores",
Expand Down
4 changes: 4 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ class LookMLSourceConfig(LookerCommonConfig, StatefulIngestionConfigBase):
None,
description="Required if not providing github configuration and deploy keys. A pointer to a local directory (accessible to the ingestion system) where the root of the LookML repo has been checked out (typically via a git clone). This is typically the root folder where the `*.model.lkml` and `*.view.lkml` files are stored. e.g. If you have checked out your LookML repo under `/Users/jdoe/workspace/my-lookml-repo`, then set `base_folder` to `/Users/jdoe/workspace/my-lookml-repo`.",
)
github_info: Optional[GitHubInfo] = Field(
None,
description="Reference to your github location. If present, supplies handy links to your lookml on the dataset entity page.",
)
project_dependencies: Dict[str, Union[pydantic.DirectoryPath, GitHubInfo]] = Field(
{},
description="A map of project_name to local directory (accessible to the ingestion system) or Git credentials. "
Expand Down