Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): only require github_info for lookml and not looker #6608

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix(ingest): only require github_info for lookml and not looker #6608

merged 1 commit into from
Dec 2, 2022

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 2, 2022

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Unit Test Results (metadata ingestion)

       8 files         8 suites   58m 52s ⏱️
   765 tests    763 ✔️ 2 💤 0 ❌
1 532 runs  1 527 ✔️ 5 💤 0 ❌

Results for commit 1ec7ad2.

@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Unit Test Results (build & test)

621 tests  ±0   617 ✔️ ±0   15m 46s ⏱️ +12s
157 suites ±0       4 💤 ±0 
157 files   ±0       0 ❌ ±0 

Results for commit 1ec7ad2. ± Comparison against base commit 6e31754.

treff7es
treff7es approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 71466aa into datahub-project:master Dec 2, 2022
@hsheth2 hsheth2 deleted the lookml-github branch December 2, 2022 19:18
cccs-Dustin pushed a commit to CybercentreCanada/datahub that referenced this pull request Feb 1, 2023
@hsheth2 @cccs-Dustin
fix(ingest): only require github_info for lookml and not looker (data…
3d0435a 
…hub-project#6608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es