Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove back-ticks from table name when creating urn #6236

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix(ingest): remove back-ticks from table name when creating urn #6236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e0286
fix(ingest): remove backticks from table name when creating urn
mayurinehate Oct 19, 2022
89d53a1
update comment
mayurinehate Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,12 @@ def get_fully_qualified_table_name(
# do some final adjustments on the fully qualified table name to help them line up with source systems:
# lowercase it
fully_qualified_table_name = fully_qualified_table_name.lower()
# strip double quotes and escaped double quotes
# strip double quotes, escaped double quotes and backticks
fully_qualified_table_name = (
fully_qualified_table_name.replace('\\"', "").replace('"', "").replace("\\", "")
fully_qualified_table_name.replace('\\"', "")
.replace('"', "")
.replace("\\", "")
.replace("`", "")
)

if platform in ("athena", "hive", "mysql"):
Expand Down