Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): remove back-ticks from table name when creating urn #6236

Merged
merged 2 commits into from
Oct 19, 2022
Merged

fix(ingest): remove back-ticks from table name when creating urn #6236

merged 2 commits into from
Oct 19, 2022

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 19, 2022
@github-actions
Copy link

github-actions bot commented Oct 19, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       8 files         8 suites   57m 39s ⏱️
   745 tests    742 ✔️ 3 💤 0 ❌
1 492 runs  1 486 ✔️ 6 💤 0 ❌

Results for commit 89d53a1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 19, 2022 •
edited
Loading

Unit Test Results (build & test)

597 tests  ±0   593 ✔️ ±0   12m 1s ⏱️ +23s
147 suites ±0       4 💤 ±0 
147 files   ±0       0 ❌ ±0 

Results for commit 89d53a1. ± Comparison against base commit 98eba90.

♻️ This comment has been updated with latest results.

treff7es
treff7es approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@treff7es treff7es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@treff7es treff7es merged commit 6373c43 into datahub-project:master Oct 19, 2022
anthonyhungnguyen pushed a commit to anthonyhungnguyen/zlp-datahub that referenced this pull request Nov 8, 2022
@mayurinehate
fix(ingest): snowflake - remove back-ticks from table name when creat…
07b3e44 
…ing urn (datahub-project#6236)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
fix(ingest): snowflake - remove back-ticks from table name when creat…
ba3b60a 
…ing urn (datahub-project#6236)
cccs-tom pushed a commit to CybercentreCanada/datahub that referenced this pull request Nov 18, 2022
@mayurinehate @cccs-tom
fix(ingest): snowflake - remove back-ticks from table name when creat…
de170cc 
…ing urn (datahub-project#6236)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @treff7es