Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion) Fetch live logs on an ingestion run from UI #5653

Merged

Conversation

chriscollins3456
Copy link
Collaborator

When viewing ingestion run details in the modal, continuously refetch to get updated logs every 2 seconds if the status of the ingestion run is RUNNING. Related to this, this PR also adds ingestion summary text for all ingestion run statuses and swaps the disabled "Execute" button for the actively running ingestion source to be a "Details" button that opens the summary modal.

This also cleans a few other things up.

  • Add the ability to hide expanded logs if you expand them
  • Hide "Show more" if you can't expand in the first place
  • Prevent indefinite polling to get all ingestion sources after executing a run once we no longer have any sources that are RUNNING. Happens when we execute and even after the run is complete we poll until you refresh the page.
  • Related ^ start polling for all ingestion sources if we have one that is RUNNING. This would be an issue if the user comes to the ingestion page and there is a source running, but we aren't polling so it will never update.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@maggiehays maggiehays added the product PR or Issue related to the DataHub UI/UX label Aug 16, 2022
@github-actions
Copy link

github-actions bot commented Aug 16, 2022

Unit Test Results (build & test)

504 tests  ±0   504 ✔️ ±0   9m 23s ⏱️ +55s
117 suites ±0       0 💤 ±0 
117 files   ±0       0 ±0 

Results for commit d6c2f46. ± Comparison against base commit 9143663.

♻️ This comment has been updated with latest results.

@@ -55,6 +55,21 @@ export const getExecutionRequestStatusDisplayText = (status: string) => {
);
};

export const getExecutionRequestSummaryText = (status: string) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jjoyce0510 jjoyce0510 merged commit acddbee into datahub-project:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants