final cleanups

datahub-project · Aug 16, 2022 · d6c2f46 · d6c2f46
1 parent b78da41
commit d6c2f46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/datahub-web-react/src/app/ingest/source/ExecutionRequestDetailsModal.tsx b/datahub-web-react/src/app/ingest/source/ExecutionRequestDetailsModal.tsx
@@ -169,18 +169,9 @@ export const ExecutionDetailsModal = ({ urn, visible, onClose }: Props) => {
                     <Typography.Paragraph ellipsis>
                         <pre>{`${logs}${!showExpandedLogs ? '...' : ''}`}</pre>
                         {isOutputExpandable && (
-                            <>
-                                {!showExpandedLogs && (
-                                    <ShowMoreButton type="link" onClick={() => setShowExpandedLogs(true)}>
-                                        Show More
-                                    </ShowMoreButton>
-                                )}
-                                {showExpandedLogs && (
-                                    <ShowMoreButton type="link" onClick={() => setShowExpandedLogs(false)}>
-                                        Hide
-                                    </ShowMoreButton>
-                                )}
-                            </>
+                            <ShowMoreButton type="link" onClick={() => setShowExpandedLogs(!showExpandedLogs)}>
+                                {showExpandedLogs ? 'Hide' : 'Show More'}
+                            </ShowMoreButton>
                         )}
                     </Typography.Paragraph>
                 </LogsSection>

diff --git a/datahub-web-react/src/app/ingest/source/IngestionSourceList.tsx b/datahub-web-react/src/app/ingest/source/IngestionSourceList.tsx
@@ -95,6 +95,7 @@ export const IngestionSourceList = () => {
     const [lastRefresh, setLastRefresh] = useState(0);
     // Set of removed urns used to account for eventual consistency
     const [removedUrns, setRemovedUrns] = useState<string[]>([]);
+    const [refreshInterval, setRefreshInterval] = useState<NodeJS.Timeout | null>(null);
 
     // Ingestion Source Queries
     const { loading, error, data, refetch } = useListIngestionSourcesQuery({
@@ -125,8 +126,6 @@ export const IngestionSourceList = () => {
         setLastRefresh(new Date().getMilliseconds());
     }, [refetch]);
 
-    const [refreshInterval, setRefreshInterval] = useState<NodeJS.Timeout | null>(null);
-
     useEffect(() => {
         const runningSource = filteredSources.find((source) =>
             source.executions?.executionRequests.find((request) => request.result?.status === RUNNING),