Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata-models) bridge gaps between graphql and pegasus models #10692

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix(metadata-models) bridge gaps between graphql and pegasus models #10692

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3b00e4
feat(metadata-models) cron schedule model
jayacryl Jun 12, 2024
df13d2c
aligned assertion model
jayacryl Jun 12, 2024
651ac28
brought over since the last check freshness types
jayacryl Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions datahub-graphql-core/src/main/resources/entity.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7658,6 +7658,16 @@ enum AssertionStdOperator {
"""
EQUAL_TO

"""
Value being asserted is not equal to value
"""
NOT_EQUAL_TO

"""
Value being asserted is null
"""
NULL

"""
Value being asserted is not null
"""
Expand Down Expand Up @@ -7694,12 +7704,12 @@ enum AssertionStdOperator {
NOT_IN

"""
Value being asserted is true.
Value being asserted is true
"""
IS_TRUE

"""
Value being asserted is false.
Value being asserted is false
"""
IS_FALSE

Expand Down
16 changes: 16 additions & 0 deletions metadata-models/src/main/pegasus/com/linkedin/common/CronSchedule.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
namespace com.linkedin.common

/**
* Attributes defining a CRON-formatted schedule.
*/
record CronSchedule {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end uses it for typing in a handful of places and it's used in SaaS for the backend in AssertionEvaluationSpec. I thought it'd be better to pull this model in for future uses too than try to refactor frontend on both OSS/SaaS to map CronSchedule from the backend type to a new frontend CronSchedule type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

/**
* A cron-formatted execution interval, as a cron string, e.g. 1 * * * *
*/
cron: string

/**
* Timezone in which the cron interval applies, e.g. America/Los Angeles
*/
timezone: string
}
Loading