Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata-models) bridge gaps between graphql and pegasus models #10692

Merged
merged 3 commits into from
Jun 12, 2024
Merged

fix(metadata-models) bridge gaps between graphql and pegasus models #10692

merged 3 commits into from
Jun 12, 2024

Conversation

jayacryl
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the community-contribution PR or Issue raised by member(s) of DataHub Community label Jun 12, 2024
@jayacryl jayacryl changed the title feat(metadata-models) cron schedule model fix(metadata-models) bridge gaps between graphql and pegasus models Jun 12, 2024
jjoyce0510
jjoyce0510 reviewed Jun 12, 2024
View reviewed changes
metadata-models/src/main/pegasus/com/linkedin/common/CronSchedule.pdl
/**
* Attributes defining a CRON-formatted schedule.
*/
record CronSchedule {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The front end uses it for typing in a handful of places and it's used in SaaS for the backend in AssertionEvaluationSpec. I thought it'd be better to pull this model in for future uses too than try to refactor frontend on both OSS/SaaS to map CronSchedule from the backend type to a new frontend CronSchedule type.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

jjoyce0510
jjoyce0510 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayacryl jayacryl merged commit 71f9574 into master Jun 12, 2024
62 of 63 checks passed
@jayacryl jayacryl deleted the jp--cron-schedule-data-model branch June 12, 2024 19:29
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@jayacryl @sleeperdeep
fix(metadata-models) bridge gaps between graphql and pegasus models (d…
38eee1b 
…atahub-project#10692)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@jayacryl @yoonhyejin
fix(metadata-models) bridge gaps between graphql and pegasus models (#…
d2b8f49 
…10692)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @jjoyce0510