Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): fixes issue where exact match exclusive flag broke quoted structured search #10690

Merged

Conversation

nmbryant
Copy link
Contributor

@nmbryant nmbryant commented Jun 12, 2024

Related to this issue: #10505
We found that enabling the flag ELASTICSEARCH_QUERY_EXACT_MATCH_EXCLUSIVE resolved the problem where quoted search with _ or - had no effect. However, enabling this flag broke structured queries tat had quotes (which are needed if the search string contains a space) due to the check that has been removed by this PR.

It seems that this logic isn't intended and was just an artifact of modeling the function getStructuredQuery after the getSimpleQuery function:

executeSimpleQuery = !(isQuoted(sanitizedQuery) && exactMatchConfiguration.isExclusive());

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 12, 2024
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@david-leifker david-leifker merged commit 8705d97 into datahub-project:master Jun 14, 2024
41 of 42 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants