Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 quoted search not working on preprod #783

Closed
MatMoore opened this issue Sep 5, 2024 · 1 comment
Closed

🐛 quoted search not working on preprod #783

MatMoore opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MatMoore
Copy link
Contributor

MatMoore commented Sep 5, 2024

Describe the bug.

prod is working, preprod returns no matches for a quoted search, e.g. "Common platform"

this is after updating datahub

see https://datahubproject.io/docs/releases/#v0-14-0-2

To Reproduce

No response

Expected Behaviour

No response

Additional context

No response

@MatMoore MatMoore added the bug Something isn't working label Sep 5, 2024
@mitchdawson1982 mitchdawson1982 self-assigned this Sep 12, 2024
@mitchdawson1982
Copy link
Collaborator

mitchdawson1982 commented Sep 16, 2024

Quoted searches with underscores do now return exact matches however It looks as though search behaviour has been changed in the latest datahub version. Search terms will be treated as exact matches if they match the regex below.

# Criteria for exact-match only
  # Contains quotes, is a single term with `_`, `.`, or `-` (normally consider for tokenization) then use exact match query
  - queryRegex: >-
      ^["'].+["']$|^[a-zA-Z0-9]\S+[_.-]\S+[a-zA-Z0-9]$
    simpleQuery: false
    prefixMatchQuery: false
    exactMatchQuery: true

Dev Datahub behaviour

Search Term Results
pnc 85
pnc_ 82
pnc_ids 0
pnc_ids_ 82
pnc_ids_t 0
pnc_ids_transformed 1
pnc ids 82
pnc ids transformed 3
"pnc_ids_transformed" 1

@mitchdawson1982 mitchdawson1982 closed this as completed by moving to Done in Data Catalogue Sep 17, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Data Catalogue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done ✅
Development

No branches or pull requests

2 participants