This repository has been archived by the owner on Jul 25, 2022. It is now read-only.
#45 Add register_table/deregister_table and expose some public mod #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 2, 2022
Closed
jychen7
commented
Apr 3, 2022
| @@ -38,8 +38,8 @@ uuid = { version = "0.8", features = ["v4"] } | |||
| mimalloc = { version = "*", default-features = false } | |||
|
|
|||
| [lib] | |||
| name = "_internal" | |||
| crate-type = ["cdylib"] | |||
| name = "datafusion_python" | |||
There was a problem hiding this comment.
jychen7
commented
Apr 3, 2022
| from datafusion import ExecutionContext | ||
|
|
||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
moved to datafusion/tests/conftest.py for shared usage in test_context and test_sql
jychen7
commented
Apr 3, 2022
| @@ -38,7 +38,7 @@ pub(crate) struct PyDatabase { | |||
| } | |||
|
|
|||
| #[pyclass(name = "Table", module = "datafusion", subclass)] | |||
| pub(crate) struct PyTable { | |||
| pub struct PyTable { | |||
There was a problem hiding this comment.
jychen7
commented
Apr 3, 2022
| @@ -25,7 +25,7 @@ use datafusion::physical_plan::functions::Volatility; | |||
| use crate::errors::DataFusionError; | |||
|
|
|||
| /// Utility to collect rust futures with GIL released | |||
| pub(crate) fn wait_for_future<F: Future>(py: Python, f: F) -> F::Output | |||
| pub fn wait_for_future<F: Future>(py: Python, f: F) -> F::Output | |||
There was a problem hiding this comment.
jychen7
changed the title
|
@jimexist , see if you have time to take a look also cc @matthewmturner (from Q2 plan, I saw you have interest in python binding as well) |
jimexist
approved these changes
Apr 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #45
prerequisite for datafusion-contrib/datafusion-bigtable#3