Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python binding and integrate with datafusion-python #3

Closed
wants to merge 3 commits into from

Conversation

jychen7
Copy link
Member

@jychen7 jychen7 commented Apr 2, 2022

depends on datafusion-contrib/datafusion-python#46

PyBigtableTable is a subclass of PyTable (in pyo3 word, it extends=PyTable)

result = ctx.sql(
"SELECT region, balloon_id, event_minute, temperature, \"_timestamp\" FROM weather_balloons where region = 'us-west2' and balloon_id IN ('3698') and event_minute BETWEEN '2021-03-05-1200' AND '2021-03-05-1201' ORDER BY \"_timestamp\""
).collect()
assert result.to_pydict() == {}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: compile successfully locally (macOS) and fix this test expect output

pyo3 = { version = "~0.15", features = ["extension-module"] }
tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync"] }
datafusion = { version = "^7.0.0", features = ["pyarrow"] }
datafusion-python = { git = "https://github.com/jychen7/datafusion-python", branch = "register-table" }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


[packages]
maturin = "==0.12.11"
datafusion = "==0.5.1"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgrade to new version after PR datafusion-contrib/datafusion-python#46

@jychen7
Copy link
Member Author

jychen7 commented Apr 15, 2022

The PR doesn't work because of limitation of pyo3 cross package inheritance
PyO3/pyo3#1444

detail can be found here
datafusion-contrib/datafusion-python#45 (comment)

@jychen7 jychen7 closed this Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant