-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build on Java 21 #982
Merged
Build on Java 21 #982
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7c36852
Build on Java 21 (temurin doesn't support Java 21 yet, so moved to Co…
bodiam 0b5ce68
Passing experimental flag to Bytebuddy until Mockito creates a new re…
bodiam b1957c2
Passing experimental flag to Bytebuddy until Mockito creates a new re…
bodiam 27d929b
Use quotes for mvn args and exclude byte-buddy for assertj
snuyanzin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ on: | |
| branches: [ main, 1.x ] | ||
|
|
||
| env: | ||
| mvn_options: --batch-mode -Dstyle.color=always -Dorg.slf4j.simpleLogger.showDateTime=true -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS | ||
| mvn_options: --batch-mode -Dnet.bytebuddy.experimental=true -Dstyle.color=always -Dorg.slf4j.simpleLogger.showDateTime=true -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss.SSS | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
@@ -29,6 +29,6 @@ jobs: | |
| distribution: 'corretto' | ||
| cache: maven | ||
| - name: Build with Maven | ||
| run: ./mvnw $mvn_options verify -PnoGpg --file pom.xml -Dnet.bytebuddy.experimental=true | ||
| run: ./mvnw $mvn_options verify -PnoGpg --file pom.xml | ||
| - name: Upload coverage to Codecov | ||
| uses: codecov/[email protected] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
no need for
=truethis should be enough
-Dnet.bytebuddy.experimentalThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just stole it from here: raphw/byte-buddy#1396
either way, this should be a temporary solution until Mockito releases things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this Windows Build doesn't want to start or finish.
update Ah, seems like the old build was stuck, preventing the new one from running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I re-ran failed (which includes cancelled). Fingers crossed it actually runs this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cancelled the build, triggered it again, but seems no luck.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait till the end to see exception
i guess there should be timeout something about an hour
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems I found the reason
mockito(5.5.0) depends onbyte-buddy1.14.6mvn dependency:treeshows that it usesbyte-buddy1.12.11assertj-coreAs a result exclusion of
byte-buddyfromassertj-coresolves the issue and makes it usingbyte-buddyfrommockitoas a bonus after that there is no need for
-Dnet.bytebuddy.experimentalat allThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for tackling that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I see that AssertJ did upgrade: https://github.com/assertj/assertj/blob/main/assertj-core/pom.xml#L31, they just haven't released a version in a while.