Build on Java 21

[bodiam]

(temurin doesn't support Java 21 yet, so moved to Corretto for the time being)

[what-the-diff]

PR Summary

• Update of Java Version Matrix
  The versions of Java that our software checks against have been updated. We were previously testing against version 17 and 20, but now we're also going to check against version 21. This update ensures that we stay compatible with the latest version of Java.

• Change in Java Distribution
  We've switched from using 'Temurin' to 'Corretto' as our Java distribution. This change was made to use a Java distribution that may work better for our specific needs.

• Modification of Maven Build Command
  In the commands we use to build our software with Maven, we've started using the $mvn_options variable and turned on the -PnoGpg option. This update should give us better control over the build process and disable GPG signing during the build, providing a more efficient process.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.32%. Comparing base (e6e1e76) to head (27d929b).
Report is 418 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #982      +/-   ##
============================================
- Coverage     92.37%   92.32%   -0.06%     
+ Complexity     2761     2759       -2     
============================================
  Files           289      289              
  Lines          5523     5523              
  Branches        602      602              
============================================
- Hits           5102     5099       -3     
- Misses          269      270       +1     
- Partials        152      154       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[snuyanzin]

nit:
no need for =true
this should be enough
-Dnet.bytebuddy.experimental

[bodiam]

I just stole it from here: raphw/byte-buddy#1396

either way, this should be a temporary solution until Mockito releases things.

[snuyanzin]

+1

[bodiam]

Seems this Windows Build doesn't want to start or finish.

update Ah, seems like the old build was stuck, preventing the new one from running.

[kingthorin]

👍

I re-ran failed (which includes cancelled). Fingers crossed it actually runs this time.

[bodiam]

I cancelled the build, triggered it again, but seems no luck.

[snuyanzin]

let's wait till the end to see exception
i guess there should be timeout something about an hour

[snuyanzin]

seems I found the reason

1. mockito (5.5.0) depends on byte-buddy 1.14.6
2. mvn dependency:tree shows that it uses byte-buddy 1.12.11
3. it comes from assertj-core

As a result exclusion of byte-buddy from assertj-core solves the issue and makes it using byte-buddy from mockito
as a bonus after that there is no need for -Dnet.bytebuddy.experimental at all

[kingthorin]

Nice! Thanks for tackling that.

[bodiam]

Nice! I see that AssertJ did upgrade: https://github.com/assertj/assertj/blob/main/assertj-core/pom.xml#L31, they just haven't released a version in a while.