Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email notification recipients #1090

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Update email notification recipients #1090

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc0aaac
Update email notification recipients
hqpho Oct 12, 2024
7495ae6
Fix formatting
hqpho Oct 14, 2024
4f0ab1c
Also send failure notifications to debug list
hqpho Oct 18, 2024
e1fdff4
Merge branch 'master' into alerts
hqpho Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions import-automation/executor/app/executor/import_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
from app.service import import_service

# Email address for status messages.
_SUCCESS_EMAIL_ADDR = 'datacommons+release@google.com'
_FAILURE_EMAIL_ADDR = 'datacommons-alerts+importautomation@google.com'
_DEBUG_EMAIL_ADDR = 'datacommons-debug+imports@google.com'
_ALERT_EMAIL_ADDR = 'datacommons-alerts+imports@google.com'

_SEE_LOGS_MESSAGE = (
'Please find logs in the Logs Explorer of the GCP project associated with'
Expand Down Expand Up @@ -300,7 +300,7 @@ def _import_one(
self.notifier.send(
subject=f'Import Automation Success - {import_name}',
body=msg,
receiver_addresses=[_SUCCESS_EMAIL_ADDR],
receiver_addresses=[_DEBUG_EMAIL_ADDR],
)

except Exception as exc:
Expand All @@ -312,7 +312,7 @@ def _import_one(
self.notifier.send(
subject=f'Import Automation Failure - {import_name}',
body=msg,
receiver_addresses=[_FAILURE_EMAIL_ADDR],
receiver_addresses=[_ALERT_EMAIL_ADDR, _DEBUG_EMAIL_ADDR],
)
raise exc

Expand Down
Loading