Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update email notification recipients #1090

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

hqpho
Copy link
Contributor

@hqpho hqpho commented Oct 12, 2024

  • Use datacommons-debug for successes and failures
  • Use datacommons-alerts for failures
  • Use category alias +imports for both addresses

@hqpho hqpho requested a review from ajaits October 14, 2024 19:53
@hqpho hqpho unassigned beets Oct 14, 2024
Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think failure and success emails should both go to the same place. can we update failures to be sent to both places? it'll be much easier to find a complete record of all the runs in a single place.

@hqpho
Copy link
Contributor Author

hqpho commented Oct 18, 2024

i think failure and success emails should both go to the same place. can we update failures to be sent to both places? it'll be much easier to find a complete record of all the runs in a single place.

Done!

@hqpho hqpho requested a review from beets October 18, 2024 21:37
Copy link
Contributor

@beets beets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update

@hqpho hqpho merged commit fd21052 into datacommonsorg:master Oct 18, 2024
9 checks passed
@hqpho hqpho deleted the alerts branch October 18, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants