Clean pandas usage in frame.agg #821
Conversation
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 94.36% 94.36% -0.01%
==========================================
Files 32 32
Lines 5854 5853 -1
==========================================
- Hits 5524 5523 -1
Misses 330 330
Continue to review full report at Codecov.
|
databricks/koalas/frame.py
Outdated
| lambda gpdf: gpdf.drop('level_1', 1).set_index('level_0').transpose() | ||
| ).reset_index(level=1) | ||
| pdf = pdf.drop(columns='level_1') | ||
| pdf = kdf.to_pandas().stack(level=1) |
There was a problem hiding this comment.
We can just use .stack() here? Then I guess we can reuse when supporting multi-index columns.
There was a problem hiding this comment.
yeah, .stack() should also work indeed. i was trying to be more explicit. Use .stack() to facilitate supporting multiindex, will change!
thanks! @ueshin
Softagram Impact Report for pull/821 (head commit: a23fc27)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
|
Thanks! merging. |
|
Nice! Thanks! |
* upstream/master: Updated the koalas logo in readme.md Adding koalas-logo without label Adding Koalas logo to readme Adding koalas logo Clean pandas usage in frame.agg (databricks#821) Implement Series.aggregate and agg (databricks#816) Raise a more helpful error for duplicated columns in Join (databricks#820)
I came across the
frame.aggwhen i read through code base, and based on the inline comment, I think the manipulation using pandas could be simplified a bit IIUC.