Raise a more helpful error for duplicated columns in Join #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Softagram Impact Report for pull/820 (head commit: 08f25bd)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
- Coverage 94.33% 92.68% -1.66%
==========================================
Files 32 32
Lines 5844 5849 +5
==========================================
- Hits 5513 5421 -92
- Misses 331 428 +97
Continue to review full report at Codecov.
|
HyukjinKwon
approved these changes
Sep 23, 2019
ueshin
reviewed
Sep 23, 2019
| with self.assertRaisesRegex(ValueError, | ||
| "columns overlap but no suffix specified"): | ||
| kdf1.join(ks1, how='outer') | ||
| kdf1.join(kdf2, how='outer') |
There was a problem hiding this comment.
Actually this only tests the first line.
There was a problem hiding this comment.
Ah yes. Sorry for missing this one will take a closer look next time @ueshin
thoo
added a commit
to thoo/koalas
that referenced
this pull request
Sep 24, 2019
* upstream/master: Updated the koalas logo in readme.md Adding koalas-logo without label Adding Koalas logo to readme Adding koalas logo Clean pandas usage in frame.agg (databricks#821) Implement Series.aggregate and agg (databricks#816) Raise a more helpful error for duplicated columns in Join (databricks#820)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #819
Raise an error
>>> ValueError: columns overlap but no suffix specified: ['letter']if the duplicated column(s) is found but no suffix is specified.Also added the pytests.