BUG: Allow default config option to be None #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Softagram Impact Report for pull/738 (head commit: 5879370)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
charlesdong1991
changed the title
Codecov Report
@@ Coverage Diff @@
## master #738 +/- ##
==========================================
+ Coverage 94.4% 94.41% +<.01%
==========================================
Files 32 32
Lines 5580 5584 +4
==========================================
+ Hits 5268 5272 +4
Misses 312 312
Continue to review full report at Codecov.
|
This was referenced Sep 3, 2019
|
Let's track it here #739 |
HyukjinKwon
added a commit
that referenced
this pull request
Sep 4, 2019
…739) This PR takes over #738, and this fix was inspired by the PR. So the commit credits to, and is authored by @charlesdong1991. This PR adds `Option` class to allow various cases such as type checking, value checking, etc. See the usage below as a example ```python Option( key='compute.default_index_type', doc=( "This sets the default index type: sequence, distributed and distributed-sequence."), default='sequence', types=str, check_func=( lambda v: v in ('sequence', 'distributed', 'distributed-sequence'), "Index type should be one of 'sequence', 'distributed', 'distributed-sequence'.")) ``` While I am here, I also fixed `plotting.sample_ratio` respects `plotting.max_rows` by default if this is not set. Also, let `DataFrame.transform` respect `compute.max_rows` as well with minor cleanups.
HyukjinKwon
pushed a commit
that referenced
this pull request
Sep 4, 2019
…739) This PR takes over #738, and this fix was inspired by the PR. So the commit credits to, and is authored by @charlesdong1991. This PR adds `Option` class to allow various cases such as type checking, value checking, etc. See the usage below as a example ```python Option( key='compute.default_index_type', doc=( "This sets the default index type: sequence, distributed and distributed-sequence."), default='sequence', types=str, check_func=( lambda v: v in ('sequence', 'distributed', 'distributed-sequence'), "Index type should be one of 'sequence', 'distributed', 'distributed-sequence'.")) ``` While I am here, I also fixed `plotting.sample_ratio` respects `plotting.max_rows` by default if this is not set. Also, let `DataFrame.transform` respect `compute.max_rows` as well with minor cleanups.
rising-star92
added a commit
to rising-star92/databricks-koalas
that referenced
this pull request
Jan 27, 2023
…#739) This PR takes over databricks/koalas#738, and this fix was inspired by the PR. So the commit credits to, and is authored by @charlesdong1991. This PR adds `Option` class to allow various cases such as type checking, value checking, etc. See the usage below as a example ```python Option( key='compute.default_index_type', doc=( "This sets the default index type: sequence, distributed and distributed-sequence."), default='sequence', types=str, check_func=( lambda v: v in ('sequence', 'distributed', 'distributed-sequence'), "Index type should be one of 'sequence', 'distributed', 'distributed-sequence'.")) ``` While I am here, I also fixed `plotting.sample_ratio` respects `plotting.max_rows` by default if this is not set. Also, let `DataFrame.transform` respect `compute.max_rows` as well with minor cleanups.
rising-star92
added a commit
to rising-star92/databricks-koalas
that referenced
this pull request
Jan 27, 2023
…#739) This PR takes over databricks/koalas#738, and this fix was inspired by the PR. So the commit credits to, and is authored by @charlesdong1991. This PR adds `Option` class to allow various cases such as type checking, value checking, etc. See the usage below as a example ```python Option( key='compute.default_index_type', doc=( "This sets the default index type: sequence, distributed and distributed-sequence."), default='sequence', types=str, check_func=( lambda v: v in ('sequence', 'distributed', 'distributed-sequence'), "Index type should be one of 'sequence', 'distributed', 'distributed-sequence'.")) ``` While I am here, I also fixed `plotting.sample_ratio` respects `plotting.max_rows` by default if this is not set. Also, let `DataFrame.transform` respect `compute.max_rows` as well with minor cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current setup, when using
set_option, it will first check if the given value has the same type of default value. In this way, if the default is set toNonewhich will result inNoneTypein the type checking and thus fail to useset_option.And because of this, the PR #737 will fail, if this PR is merged, the #737 will be changed to adopt this.