-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add plotting.sample_ratio in config #737
ENH: Add plotting.sample_ratio in config #737
Conversation
Softagram Impact Report for pull/737 (head commit: d387802)⭐ Change Overview
📄 Full report
Impact Report explained. Give feedback on this report to [email protected] |
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 94.4% 92.01% -2.39%
==========================================
Files 32 32
Lines 5580 5588 +8
==========================================
- Hits 5268 5142 -126
- Misses 312 446 +134
Continue to review full report at Codecov.
|
fraction = sample_ratio | ||
|
||
# check if fraction is larger than 1, and ceil it to 1 if so | ||
if fraction > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need a way to check the value set in its options at #738 .. hm .. let me think about this a bit more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, how about checking the value here? so if fraction is given a number larger than 1, the raise an error/warning message? feel like checking the value as well in options sounds a bit overkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there are some other cases where we need to check values like default index type .. I tried to integrate convert / check logics at #739 to make it less overkill. Please take a look when you are available.
And technically we can set upper/lower bounds for other cases too (e.g., only positive numbers).
Let me just merge and make a followup. Thanks for working on this @charlesdong1991 |
No description provided.