Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add plotting.sample_ratio in config #737

Merged

Conversation

charlesdong1991
Copy link
Contributor

No description provided.

@softagram-bot
Copy link

Softagram Impact Report for pull/737 (head commit: d387802)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to [email protected]

@codecov-io
Copy link

Codecov Report

Merging #737 into master will decrease coverage by 2.38%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage    94.4%   92.01%   -2.39%     
==========================================
  Files          32       32              
  Lines        5580     5588       +8     
==========================================
- Hits         5268     5142     -126     
- Misses        312      446     +134
Impacted Files Coverage Δ
databricks/koalas/plot.py 93.88% <100%> (-1.03%) ⬇️
databricks/koalas/config.py 100% <100%> (ø) ⬆️
databricks/koalas/usage_logging/__init__.py 23.14% <0%> (-74.08%) ⬇️
databricks/koalas/usage_logging/usage_logger.py 50% <0%> (-50%) ⬇️
databricks/koalas/__init__.py 77.5% <0%> (-7.5%) ⬇️
databricks/conftest.py 90.69% <0%> (-6.98%) ⬇️
databricks/koalas/frame.py 93.4% <0%> (-1.73%) ⬇️
databricks/koalas/namespace.py 92.15% <0%> (-1.57%) ⬇️
databricks/koalas/utils.py 97.24% <0%> (-0.69%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b876400...d387802. Read the comment docs.

fraction = sample_ratio

# check if fraction is larger than 1, and ceil it to 1 if so
if fraction > 1:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a way to check the value set in its options at #738 .. hm .. let me think about this a bit more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, how about checking the value here? so if fraction is given a number larger than 1, the raise an error/warning message? feel like checking the value as well in options sounds a bit overkill

Copy link
Member

@HyukjinKwon HyukjinKwon Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there are some other cases where we need to check values like default index type .. I tried to integrate convert / check logics at #739 to make it less overkill. Please take a look when you are available.

And technically we can set upper/lower bounds for other cases too (e.g., only positive numbers).

@HyukjinKwon
Copy link
Member

Let me just merge and make a followup.

Thanks for working on this @charlesdong1991

@HyukjinKwon HyukjinKwon merged commit ed2c9ad into databricks:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants