Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change matplotlib as an optional dependency #2029

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 1, 2021

This PR proposes to change matplotlib as an optional dependency.

>>> from databricks import koalas as ks
>>> ks.range(100).plot.bar()
Traceback (most recent call last):
  ...
ImportError: matplotlib is required for plotting when the default backend 'matplotlib' is selected.

Resolves #2023

Copy link
Collaborator

@ueshin ueshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we move it to Optional dependencies in Koalas. in requirements-dve.txt as well?
Otherwise, LGTM.

@HyukjinKwon HyukjinKwon merged commit 5e28195 into databricks:master Feb 2, 2021
@xinrong-meng
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas doesn't require matplotlib, koalas shouldn't either.
3 participants