Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas doesn't require matplotlib, koalas shouldn't either. #2023

Closed
jimfulton opened this issue Jan 27, 2021 · 5 comments · Fixed by #2029
Closed

Pandas doesn't require matplotlib, koalas shouldn't either. #2023

jimfulton opened this issue Jan 27, 2021 · 5 comments · Fixed by #2029
Labels
enhancement New feature or request

Comments

@jimfulton
Copy link

Pandas will use matplotlib if it's available, but matplotlib isn't a dependency if Pandas.

We're deploying batch-processing applications for use in data pipelines, which will never try to plot anything and don't need matplotlib.

We are required to scan our deployments with Veracode, and Veracode raises many issues with matplotlib and matplotlib's dependencies.

We can work around this by replacing databricks.koalas.plot.KoalasPlotAccessor with a unittest.mock.MagicMock, but that's evil. :)

Koalas shouldn't require matplotlib.

@HyukjinKwon
Copy link
Member

Yeah, I think we can keep it as an optional dependency

@HyukjinKwon
Copy link
Member

Fixed in #2029

@jimfulton
Copy link
Author

Thanks!

@jimfulton
Copy link
Author

I don't want to seem ungrateful, but when might this be released? :)

@HyukjinKwon
Copy link
Member

:-). likely next week or a week after the next week. Just realised that https://koalas.readthedocs.io/en/latest/development/contributing.html#release-guide is outdated. Let me update it soon. thanks for the head up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants