-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching the behaviour to pandas>=1.0.0 at most. #1299
Matching the behaviour to pandas>=1.0.0 at most. #1299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1299 +/- ##
==========================================
- Coverage 95.07% 92.89% -2.19%
==========================================
Files 34 34
Lines 7230 7331 +101
==========================================
- Hits 6874 6810 -64
- Misses 356 521 +165
Continue to review full report at Codecov.
|
@HyukjinKwon okay i did it :) |
okay, i think the remained TODOs are almost solved, except #1299 (comment) which we decided to solve in separated PR. See the #1299 (comment) for detail of Resolved TODOs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
Follow-up for #1197
Since we're following latest version of pandas, should fix several TODOs with matching pandas>=1.0.0 for now.
For example.
the behaviour of
Expanding.count()
andExpandingGroupby.count()
are different depending on what pandas version has been installed.Since we're following latest version of pandas, need to fix this.