Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated function in MultiIndex #1140

Closed
wants to merge 1 commit into from
Closed

Add deprecated function in MultiIndex #1140

wants to merge 1 commit into from

Conversation

RainFung
Copy link
Contributor

There are many functions deprecated in Pandas 0.26 API, so I add these functions based Pandas 0.26 API in case of unnecessary coding.
https://dev.pandas.io/docs/reference/indexing.html

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #1140 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1140   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          35       35           
  Lines        7060     7060           
=======================================
  Hits         6720     6720           
  Misses        340      340
Impacted Files Coverage Δ
databricks/koalas/missing/indexes.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dff7fdd...d292e5c. Read the comment docs.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Dec 18, 2019

@RainFung, I think it's pandas 1.0.0 (not 0.26) BTW :-)

@@ -194,6 +148,52 @@ class _MissingPandasLikeMultiIndex(object):
get_values = unsupported_function('get_values', deprecated=True)
contains = unsupported_function('contains', deprecated=True)
item = unsupported_function('item', deprecated=True)
append = unsupported_function('append', deprecated=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon
Copy link
Member

Closing this. I think this is done at pandas 1.0.0 support. #1197 and #1299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants