Raise exception on unexpected error of list relations #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DatabricksAdapter is handling this exception and returns empty list of tables and further logic decides to create or replace table ... which leads to table being overwritten and all previous partitions are lost. Signed-off-by: Andre Furlan <[email protected]>
andrefurlan-db
force-pushed
the
iss266
branch
from
6a4cd71
to
a2d2364
Compare
andrefurlan-db
force-pushed
the
iss266
branch
2 times, most recently
from
a88a673
to
130d323
Compare
susodapop
previously approved these changes
Feb 17, 2023
|
I think these changes should be committed to the 1.4.latest branch rather than main, but let's expedite now and we can clean it up later. |
andrefurlan-db
force-pushed
the
iss266
branch
from
130d323
to
744cc7e
Compare
ueshin
approved these changes
Feb 17, 2023
andrefurlan-db
added a commit
that referenced
this pull request
Feb 17, 2023
Because of a AWS Glue issue, list releations was set to handle any exception and returning empty list of tables. The problem is that further logic decides to create or replace table, which leads to table being overwritten and all previous partitions are lost. I believe that the problem the previous fix solves is no where near as important to Databricks, and the problem it causes is very bad. resolves #266 Signed-off-by: Andre Furlan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of a AWS Glue issue, it was set to handle any exception and returning empty list of tables. The problem is that further logic decides to create or replace table, which leads to table being overwritten and all previous partitions are lost.
I believe that the problem the previous fix solves is no where near as important to Databricks, and the problem it causes is very bad.
resolves #266