Raise exception on unexpected error of list relations (#270)

Because of a AWS Glue issue, list releations was set to handle any exception and returning empty list of tables. The problem is that further logic decides to create or replace table, which leads to table being overwritten and all previous partitions are lost. I believe that the problem the previous fix solves is no where near as important to Databricks, and the problem it causes is very bad. resolves #266 Signed-off-by: Andre Furlan <[email protected]>
databricks · Feb 17, 2023 · 46a14bb · 46a14bb
1 parent 5c77799
commit 46a14bb
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/dbt/adapters/databricks/impl.py b/dbt/adapters/databricks/impl.py
@@ -132,7 +132,7 @@ def list_relations_without_caching(  # type: ignore[override]
             else:
                 description = "Error while retrieving information about"
                 logger.debug(f"{description} {schema_relation}: {e.msg}")
-                return []
+                raise e
 
         return [
             self.Relation.create(
@@ -164,7 +164,7 @@ def _list_relations_with_information(
             else:
                 description = "Error while retrieving information about"
                 logger.debug(f"{description} {schema_relation.without_identifier()}: {e.msg}")
-                results = []
+                raise e
 
         relations: List[Tuple[DatabricksRelation, str]] = []
         for row in results: