Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move py.typed to correct places #403

Merged
merged 7 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/code-quality-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,4 +160,7 @@ jobs:
# mypy the code
#----------------------------------------------
- name: Mypy
run: poetry run mypy --install-types --non-interactive src
run: |
cd src # Need to be in the actual databricks/ folder or mypy does the wrong thing.
mkdir .mypy_cache # Workaround for bad error message "error: --install-types failed (no mypy cache directory)"; see https://github.com/python/mypy/issues/10768#issuecomment-2178450153
poetry run mypy --config-file ../pyproject.toml --install-types --non-interactive --namespace-packages databricks
File renamed without changes.
13 changes: 6 additions & 7 deletions src/databricks/sql/utils.py
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def __init__(
schema_bytes,
max_download_threads: int,
start_row_offset: int = 0,
result_links: List[TSparkArrowResultLink] = None,
result_links: List[TSparkArrowResultLink] = [],
wyattscarpenter marked this conversation as resolved.
Show resolved Hide resolved
lz4_compressed: bool = True,
description: List[List[Any]] = None,
):
Expand All @@ -161,13 +161,12 @@ def __init__(
start_row_offset
)
)
if result_links is not None:
for result_link in result_links:
logger.debug(
"- start row offset: {}, row count: {}".format(
result_link.startRowOffset, result_link.rowCount
)
for result_link in result_links:
logger.debug(
"- start row offset: {}, row count: {}".format(
result_link.startRowOffset, result_link.rowCount
)
)

self.download_manager = ResultFileDownloadManager(
self.max_download_threads, self.lz4_compressed
Expand Down
Empty file.
Loading