Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move py.typed to correct places #403

Merged
merged 7 commits into from
Jul 2, 2024
Merged

move py.typed to correct places #403

merged 7 commits into from
Jul 2, 2024

Commits on Jun 30, 2024

  1. move py.typed to correct places

    https://peps.python.org/pep-0561/ says 'For namespace packages (see PEP 420), the py.typed file should be in the submodules of the namespace, to avoid conflicts and for clarity.'. Previously, when I added the py.typed file to this project, #382 , I was unaware this was a namespace package (although, curiously, it seems I had done it right initially and then changed to the wrong way). As PEP 561 warns us, this does create conflicts; other libraries in the databricks namespace package (such as, in my case, databricks-vectorsearch) are then treated as though they are typed, which they are not. This commit moves the py.typed file to the correct places, the submodule folders, fixing that problem.
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    4f8ee07 View commit details
    Browse the repository at this point in the history
  2. change target of mypy to src/databricks instead of src.

    I think this might fix the CI code-quality checks failure, but unfortunately I can't replicate that failure locally and the error message is unhelpful
    
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    0d1c076 View commit details
    Browse the repository at this point in the history
  3. Possible workaround for bad error message 'error: --install-types fai…

    …led (no mypy cache directory)'; see python/mypy#10768 (comment)
    
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    d148d64 View commit details
    Browse the repository at this point in the history
  4. fix invalid yaml syntax

    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f1ee456 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Best fix (#3)

    Fixes the problem by cding and supplying a flag to mypy (that mypy needs this flag is seemingly fixed/changed in later versions of mypy; but that's another pr altogether...). Also fixes a type error that was somehow in the arguments of the program (?!) (I guess this is because you guys are still using implicit optional)
    
    ---------
    
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ae1942f View commit details
    Browse the repository at this point in the history
  2. return the old result_links default (#5)

    Return the old result_links default, make the type optional, & I'm pretty sure the original problem is that add_file_links can't take a None, so these statements should be in the body of the if-statement that ensures it is not None
    
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter authored Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cb81272 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Update src/databricks/sql/utils.py

    "self.download_manager is unconditionally used later, so must be created. Looks this part of code is totally not covered with tests 🤔"
    
    Co-authored-by: Levko Kravets <[email protected]>
    Signed-off-by: wyattscarpenter <[email protected]>
    wyattscarpenter and kravets-levko committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b678e9b View commit details
    Browse the repository at this point in the history