Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notes to indicate that branch cuts follow C99 #579

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Update notes to indicate that branch cuts follow C99 #579

merged 1 commit into from
Dec 21, 2022

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Dec 21, 2022

This PR

  • updates a note indicating that branch cuts have provisional status to also indicate that branch cut conventions follow C99. While already described in the design document on complex numbers, updating the specifications for individual functions having branch cuts more explicitly conveys specification intentions and should help flag potential specification errors where guidance (mistakenly) deviates from C99.
  • addresses one of the tasks described in Tracking issue for specification maintenance tasks #533.

@kgryte kgryte added Narrative Content Narrative documentation content. topic: Complex Data Types Complex number data types. labels Dec 21, 2022
@kgryte kgryte added this to the v2022 milestone Dec 21, 2022
@kgryte kgryte mentioned this pull request Dec 21, 2022
Open
13 tasks
rgommers
rgommers approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kgryte

@rgommers rgommers merged commit b40ed89 into main Dec 21, 2022
@rgommers rgommers deleted the c99-branch-cut-notes branch December 21, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
Narrative Content Narrative documentation content. topic: Complex Data Types Complex number data types.
Projects
None yet
Milestone
v2022
Development

Successfully merging this pull request may close these issues.
2 participants
@kgryte @rgommers