Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for specification maintenance tasks #533

Open
11 of 13 tasks
kgryte opened this issue Dec 1, 2022 · 6 comments
Open
11 of 13 tasks

Tracking issue for specification maintenance tasks #533

kgryte opened this issue Dec 1, 2022 · 6 comments
Labels
Maintenance Bug fix, typo fix, or general maintenance. Tracking Issue Tracking issue.
Milestone

Comments

@kgryte
Copy link
Contributor

kgryte commented Dec 1, 2022

The purpose of this issue is to identify and track various maintenance tasks which have accumulated concerning specification organization and development.

Remaining tasks

  • Migrate special cases to use math directives: Migrate documentation of special cases to use math directives #519
  • Ensure line length is handled better, so text is readable and reviewable on GitHub without it scrolling off to the right. Either use regular line length settings (80, 88, 100, or 120 char), or set up something like EditorConfig to ensure consistent line endings and spacing.
  • Setup linting of Python files (black, pydocstyle) in CI.

Done for v2022

@kgryte kgryte added Maintenance Bug fix, typo fix, or general maintenance. Tracking Issue Tracking issue. labels Dec 1, 2022
@rgommers
Copy link
Member

rgommers commented Dec 1, 2022

Thanks for summarizing this @kgryte. A few thoughts:

  • When doing this, let's try to ensure that large content refactors do not make it harder to use git blame, by using https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
  • Some of this may be a little time-consuming. To me the higher-prio ones, good to get into the v2022 spect, are "move special cases", "move universal preamble", and "use black"
  • After that, the "use math directives one", because it's also still a big diff, so makes later maintenance easier if it's done before branching
  • Linting in CI and EditorConfig are lower prio, they can be fiddly and don't impact the 2022 content or organization of it

@rgommers
Copy link
Member

The v2022 tasks are done. I reorganized the description so it's clear what is left, and removed the milestone.

@kgryte
Copy link
Contributor Author

kgryte commented Jan 25, 2024

As commented in #689 (comment), we should investigate whether we can minimize type annotation duplication. Currently, we copy-paste the type annotation from the signature into the docstring. This increases the risk of drift, and preferably, we'd only need to write these annotations once.

@rgommers
Copy link
Member

Sphinx has functionality for that (autodoc_typehints), but like anything autodoc related it had some issues, especially with dealing with type aliases. Not sure if that has been improved recently, but I did try this when initially setting up the docs.

@rgommers
Copy link
Member

If I had to deal with this now, I'd dump Sphinx complete in favor of MkDocs / mkdocs-material.

@kgryte
Copy link
Contributor Author

kgryte commented Jan 25, 2024

Sphinx has functionality for that...I'd dump Sphinx completely...

Yeah, we should revisit once we have v2023 released.

@kgryte kgryte modified the milestones: v2023, v2024 Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Bug fix, typo fix, or general maintenance. Tracking Issue Tracking issue.
Projects
None yet
Development

No branches or pull requests

2 participants