Implement PackageInstall plugin for pip and conda
#7126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ± 0 15 suites ±0 6h 4m 45s ⏱️ - 31m 49s For more details on these failures, see this check. Results for commit 3f3ee59. ± Comparison against base commit 2196966. ♻️ This comment has been updated with latest results. |
hendrikmakait
commented
Oct 7, 2022
hendrikmakait
commented
Oct 13, 2022
crusaderky
requested changes
Oct 17, 2022
crusaderky
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7103
Introduces a
CondaInstallplugin and refactors the common logic betweenPipInstallandCondaInstallinto an abstractPackageInstallclass.pre-commit run --all-files