-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JLab 3 #217
Update to JLab 3 #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ian-r-rose! I've left a couple of questions but will defer to you on all things JupyterLab : )
The new binder/example.jupyterlab-workspace
workspace file looks very similar (though differently formatted) to the old binder/jupyterlab-workspace.json
file. What's the meaningful difference between the two?
# TODO: Importing of workspace via CLI is currently broken. | ||
# remove this workaround once https://github.com/jupyterlab/jupyterlab/issues/10805 is resolved | ||
mkdir -p ~/.jupyter/lab/workspaces/ | ||
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 37a8
part of this path seems quite specific. Why is that part needed?
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace | |
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 100% a hack -- that's a hash based on the workspace name which is not guaranteed to be stable. But I think it might be okay for the time-being, and is better than the currently broken state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha -- totally fine with me if it works
FYI there are unrelated CI failures on EDIT: I believe @bryanwweber @phobson may be trying to resolve the unrelated CI failures this afternoon |
There might not be a meaningful difference between them. Certainly one of the problems that I ran into is that some of the dashboard panels have changed names, but it depends on the specific layout. |
Which reminds me: we should check this again once we update |
@jrbourbeau Yes, I'm working on completing #215 |
- dask-labextension=2.0.2 | ||
- jupyterlab=2.1 | ||
- nodejs=16 | ||
- dask-labextension>=5.2.0 | ||
- jupyterlab>=3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces some conflicts with #218, so this should be merged first then I can fix that one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ian-r-rose -- let's give this a try!
Supersedes #187.