Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JLab 3 #217

Merged
merged 8 commits into from
May 3, 2022
Merged

Update to JLab 3 #217

merged 8 commits into from
May 3, 2022

Conversation

ian-r-rose
Copy link
Contributor

Supersedes #187.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ian-r-rose! I've left a couple of questions but will defer to you on all things JupyterLab : )

The new binder/example.jupyterlab-workspace workspace file looks very similar (though differently formatted) to the old binder/jupyterlab-workspace.json file. What's the meaningful difference between the two?

# TODO: Importing of workspace via CLI is currently broken.
# remove this workaround once https://github.com/jupyterlab/jupyterlab/issues/10805 is resolved
mkdir -p ~/.jupyter/lab/workspaces/
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 37a8 part of this path seems quite specific. Why is that part needed?

Suggested change
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace
mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% a hack -- that's a hash based on the workspace name which is not guaranteed to be stable. But I think it might be okay for the time-being, and is better than the currently broken state.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha -- totally fine with me if it works

@jrbourbeau
Copy link
Member

jrbourbeau commented May 3, 2022

FYI there are unrelated CI failures on main (xref #215), so I don't anticipate CI will pass on this PR

EDIT: I believe @bryanwweber @phobson may be trying to resolve the unrelated CI failures this afternoon

@ian-r-rose
Copy link
Contributor Author

What's the meaningful difference between the two?

There might not be a meaningful difference between them. Certainly one of the problems that I ran into is that some of the dashboard panels have changed names, but it depends on the specific layout.

@ian-r-rose
Copy link
Contributor Author

some of the dashboard panels have changed names

Which reminds me: we should check this again once we update distributed

@bryanwweber
Copy link
Contributor

@jrbourbeau Yes, I'm working on completing #215

Comment on lines -10 to +11
- dask-labextension=2.0.2
- jupyterlab=2.1
- nodejs=16
- dask-labextension>=5.2.0
- jupyterlab>=3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces some conflicts with #218, so this should be merged first then I can fix that one.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ian-r-rose -- let's give this a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants