Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update to JupyterLab 3 #187

Closed
wants to merge 3 commits into from
Closed

Conversation

jrbourbeau
Copy link
Member

Copy link
Contributor

@ian-r-rose ian-r-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ian-r-rose
Copy link
Contributor

Have you checked whether the workspace import still works? That format has historically not been especially stable

@jrbourbeau
Copy link
Member Author

jrbourbeau commented Mar 23, 2021

@jrbourbeau
Copy link
Member Author

Hmm it looks like the workspace import isn't working anymore. Were there changes on the JupyterLab side, or are the stability issues related to something else?

Screen Shot 2021-03-23 at 2 57 33 PM

@ian-r-rose
Copy link
Contributor

Probably a change in the JupyterLab side. There really isn't any guarantee of of compatibility for these files from version to version, since their primary intent is to store your ephemeral session state. If you're willing to wait a day or two on this (and the tutorials) PR, I could look into it.

@jrbourbeau
Copy link
Member Author

That'd be great whenever you get a chance -- though no rush. Upgrading to JupyterLab 3 is nice to have but not critical

@jrbourbeau jrbourbeau changed the title Update to JupyterLab 3 [WIP] Update to JupyterLab 3 Mar 23, 2021
@jacobtomlinson
Copy link
Member

The issue with workspaces should've been fixed in 3.1. I tried it out and it doesn't seem to be the case. I've tried generating a new workspace file just in case things changed from 2>3 so hopefully that will resolve it.

@jrbourbeau
Copy link
Member Author

Thanks for the update @jacobtomlinson. Trying https://mybinder.org/v2/gh/jrbourbeau/dask-examples/jlab-3?urlpath=lab again with the updated workspace file didn't seem to do the trick either

Screen Shot 2021-10-14 at 5 21 09 PM

@ian-r-rose any idea about what might be going wrong here?

@ian-r-rose
Copy link
Contributor

Thanks for picking this back up again @jacobtomlinson . I'm looking into it. Funnily enough, JupyterLab has recently gained the ability to open workspace files by double-clicking them in the filebrowser, and that basically works. The import still seems to be causing problems, however :/

@ian-r-rose
Copy link
Contributor

Update: workspace importing still seems pretty well broken (xref jupyterlab/jupyterlab#10805). I'll put a bug in Darian's ear about it

@jrbourbeau
Copy link
Member Author

Closing in favor of #217

@jrbourbeau jrbourbeau closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants