-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update to JupyterLab 3 #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Have you checked whether the workspace import still works? That format has historically not been especially stable |
Probably a change in the JupyterLab side. There really isn't any guarantee of of compatibility for these files from version to version, since their primary intent is to store your ephemeral session state. If you're willing to wait a day or two on this (and the tutorials) PR, I could look into it. |
That'd be great whenever you get a chance -- though no rush. Upgrading to JupyterLab 3 is nice to have but not critical |
The issue with workspaces should've been fixed in |
Thanks for the update @jacobtomlinson. Trying https://mybinder.org/v2/gh/jrbourbeau/dask-examples/jlab-3?urlpath=lab again with the updated workspace file didn't seem to do the trick either @ian-r-rose any idea about what might be going wrong here? |
Thanks for picking this back up again @jacobtomlinson . I'm looking into it. Funnily enough, JupyterLab has recently gained the ability to open workspace files by double-clicking them in the filebrowser, and that basically works. The import still seems to be causing problems, however :/ |
Update: workspace importing still seems pretty well broken (xref jupyterlab/jupyterlab#10805). I'll put a bug in Darian's ear about it |
Closing in favor of #217 |
cc @ian-r-rose