Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drive): additional logging and minor refactoring #1947

Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 11, 2024

Issue being fixed or feature implemented

Small refactoring and additional logging during our work on #1946 and protocol version upgrade testing

What was done?

  • Added logs
  • Minor refactoring to remove unused confusing logic in the quorum update function

How Has This Been Tested?

Running tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 11, 2024 16:44
@QuantumExplorer QuantumExplorer merged commit 9f4026f into v1.0-dev Jul 16, 2024
75 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/drive/additional-loggin-and-refactoring branch July 16, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants