Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive): valid instant lock signatures marked as invalid #1946

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 11, 2024

Issue being fixed or feature implemented

20 minutes in every hour, instant asset lock proofs are marked as invalid.

What was done?

  • Fixed chain lock previous quorums set to instant lock quorum set

How Has This Been Tested?

Added logs. Running test suite against the local network with 2.5m mining interval. Investigated logs.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 11, 2024
@shumkov shumkov changed the title fix(drive): valid instant lock signatures validated as invalid fix(drive): valid instant lock signatures marked as invalid Jul 11, 2024
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@QuantumExplorer
Copy link
Member

Merging this in.

@QuantumExplorer QuantumExplorer merged commit 1a71a33 into v1.0-dev Jul 15, 2024
12 of 16 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/drive/instant-lock-verification branch July 15, 2024 06:43
@QuantumExplorer
Copy link
Member

Well done on figuring this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants