chore(drive)!: don't use 0.0.0.0 as default listen IP
#1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
changed the title
0.0.0.0 default addresses0.0.0.0 default addresses
shumkov
changed the title
0.0.0.0 default addresses0.0.0.0 as default listen interface
shumkov
changed the title
0.0.0.0 as default listen interface0.0.0.0 as default listen ip
shumkov
changed the title
0.0.0.0 as default listen ip0.0.0.0 as default listen IP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Not a good idea to use services that bind to
0.0.0.0by defaultWhat was done?
127.0.0.1as a default interface for drive servicesHow Has This Been Tested?
None
Breaking Changes
Default bind interface for gRPC, tokio console, grovedb visualiser and others changed to
127.0.0.1Checklist:
For repository code-owners and collaborators only