chore(drive)!: don't use 0.0.0.0 as default listen IP (#1976)

dashpay · Jul 17, 2024 · 4942906 · 4942906
1 parent 811dfa0
commit 4942906
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 14 deletions.
diff --git a/packages/rs-drive-abci/.env.local b/packages/rs-drive-abci/.env.local
@@ -1,8 +1,8 @@
 # ABCI host and port to listen
-ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
-GRPC_BIND_ADDRESS="0.0.0.0:26670"
+ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
+GRPC_BIND_ADDRESS="127.0.0.1:26670"
 
-# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
+# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
 PROMETHEUS_BIND_ADDRESS=
 
 # stderr logging for humans
@@ -87,4 +87,4 @@ TOKIO_CONSOLE_ADDRESS=127.0.0.1:6669
 TOKIO_CONSOLE_RETENTION_SECS=180
 
 GROVEDB_VISUALIZER_ENABLED=false
-GROVEDB_VISUALIZER_ADDRESS=0.0.0.0:8083
+GROVEDB_VISUALIZER_ADDRESS=127.0.0.1:8083
diff --git a/packages/rs-drive-abci/.env.mainnet b/packages/rs-drive-abci/.env.mainnet
@@ -1,8 +1,8 @@
 # ABCI host and port to listen
-ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
-GRPC_BIND_ADDRESS="0.0.0.0:26670"
+ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
+GRPC_BIND_ADDRESS="127.0.0.1:26670"
 
-# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
+# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
 PROMETHEUS_BIND_ADDRESS=
 
 # stderr logging for humans

diff --git a/packages/rs-drive-abci/.env.testnet b/packages/rs-drive-abci/.env.testnet
@@ -1,8 +1,8 @@
 # ABCI host and port to listen
-ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
-GRPC_BIND_ADDRESS="0.0.0.0:26670"
+ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
+GRPC_BIND_ADDRESS="127.0.0.1:26670"
 
-# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
+# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
 PROMETHEUS_BIND_ADDRESS=
 
 # stderr logging for humans

diff --git a/packages/rs-drive-abci/src/config.rs b/packages/rs-drive-abci/src/config.rs
@@ -656,8 +656,7 @@ impl PlatformConfig {
             tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),
             initial_protocol_version: Self::default_initial_protocol_version(),
             prometheus_bind_address: None,
-            // TODO: This is dangerous. The default value must be 127.0.0.1
-            grpc_bind_address: "0.0.0.0:26670".to_string(),
+            grpc_bind_address: "127.0.0.1:26670".to_string(),
         }
     }
 
@@ -695,7 +694,7 @@ impl PlatformConfig {
             testing_configs: PlatformTestConfig::default(),
             initial_protocol_version: Self::default_initial_protocol_version(),
             prometheus_bind_address: None,
-            grpc_bind_address: "0.0.0.0:26670".to_string(),
+            grpc_bind_address: "127.0.0.1:26670".to_string(),
             tokio_console_enabled: false,
             tokio_console_address: PlatformConfig::default_tokio_console_address(),
             tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),
@@ -736,7 +735,7 @@ impl PlatformConfig {
             testing_configs: PlatformTestConfig::default(),
             initial_protocol_version: Self::default_initial_protocol_version(),
             prometheus_bind_address: None,
-            grpc_bind_address: "0.0.0.0:26670".to_string(),
+            grpc_bind_address: "127.0.0.1:26670".to_string(),
             tokio_console_enabled: false,
             tokio_console_address: PlatformConfig::default_tokio_console_address(),
             tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),