Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drive)!: don't use 0.0.0.0 as default listen IP #1976

Merged
merged 1 commit into from
Jul 17, 2024
Merged

chore(drive)!: don't use 0.0.0.0 as default listen IP #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/rs-drive-abci/.env.local
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# ABCI host and port to listen
ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
GRPC_BIND_ADDRESS="0.0.0.0:26670"
ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
GRPC_BIND_ADDRESS="127.0.0.1:26670"

# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
PROMETHEUS_BIND_ADDRESS=

# stderr logging for humans
Expand Down Expand Up @@ -87,4 +87,4 @@ TOKIO_CONSOLE_ADDRESS=127.0.0.1:6669
TOKIO_CONSOLE_RETENTION_SECS=180

GROVEDB_VISUALIZER_ENABLED=false
GROVEDB_VISUALIZER_ADDRESS=0.0.0.0:8083
GROVEDB_VISUALIZER_ADDRESS=127.0.0.1:8083
6 changes: 3 additions & 3 deletions packages/rs-drive-abci/.env.mainnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# ABCI host and port to listen
ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
GRPC_BIND_ADDRESS="0.0.0.0:26670"
ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
GRPC_BIND_ADDRESS="127.0.0.1:26670"

# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
PROMETHEUS_BIND_ADDRESS=

# stderr logging for humans
Expand Down
6 changes: 3 additions & 3 deletions packages/rs-drive-abci/.env.testnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# ABCI host and port to listen
ABCI_CONSENSUS_BIND_ADDRESS="tcp://0.0.0.0:26658"
GRPC_BIND_ADDRESS="0.0.0.0:26670"
ABCI_CONSENSUS_BIND_ADDRESS="tcp://127.0.0.1:26658"
GRPC_BIND_ADDRESS="127.0.0.1:26670"

# Metrics are disabled when empty. Must be http://0.0.0.0:29090 for example to enable
# Metrics are disabled when empty. Must be http://127.0.0.1:29090 for example to enable
PROMETHEUS_BIND_ADDRESS=

# stderr logging for humans
Expand Down
7 changes: 3 additions & 4 deletions packages/rs-drive-abci/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,7 @@ impl PlatformConfig {
tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),
initial_protocol_version: Self::default_initial_protocol_version(),
prometheus_bind_address: None,
// TODO: This is dangerous. The default value must be 127.0.0.1
grpc_bind_address: "0.0.0.0:26670".to_string(),
grpc_bind_address: "127.0.0.1:26670".to_string(),
}
}

Expand Down Expand Up @@ -695,7 +694,7 @@ impl PlatformConfig {
testing_configs: PlatformTestConfig::default(),
initial_protocol_version: Self::default_initial_protocol_version(),
prometheus_bind_address: None,
grpc_bind_address: "0.0.0.0:26670".to_string(),
grpc_bind_address: "127.0.0.1:26670".to_string(),
tokio_console_enabled: false,
tokio_console_address: PlatformConfig::default_tokio_console_address(),
tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),
Expand Down Expand Up @@ -736,7 +735,7 @@ impl PlatformConfig {
testing_configs: PlatformTestConfig::default(),
initial_protocol_version: Self::default_initial_protocol_version(),
prometheus_bind_address: None,
grpc_bind_address: "0.0.0.0:26670".to_string(),
grpc_bind_address: "127.0.0.1:26670".to_string(),
tokio_console_enabled: false,
tokio_console_address: PlatformConfig::default_tokio_console_address(),
tokio_console_retention_secs: PlatformConfig::default_tokio_console_retention_secs(),
Expand Down
Loading