Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong type of sendRawTransaction second argument #50

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

coolaj86
Copy link
Contributor

@coolaj86 coolaj86 commented Sep 22, 2022

package.json Outdated
@@ -1,7 +1,7 @@
{
"name": "@dashevo/dashd-rpc",
"description": "Dash Client Library to connect to Dash Core (dashd) via RPC",
"version": "2.4.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually bump version as a separate PR

@coolaj86 coolaj86 force-pushed the fix-dashcore-v18 branch 2 times, most recently from 15b7788 to 48bd144 Compare September 22, 2022 07:31
@coolaj86
Copy link
Contributor Author

I just tested this all with the related commits and made a few minor changes. Removed version bump here.

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov changed the title Fix sendRawTransaction for dashcore v18 fix: wrong type of sendRawTransaction second argument Sep 22, 2022
@shumkov shumkov merged commit 829acf2 into dashpay:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants