-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: swap allowAbsurdFees for maxFeeRate for Dash Core v18 #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR is incomplete. It took a few days for me to set up a full node to test (33gb of blocks and 50gb of indexes). Notes for follow up:
- sendRawTransaction: 'str bool bool',
+ sendRawTransaction: 'str float bool', Even after that change I still get: Error: "absurdly-high-fee, 383 > 373 (code 256). Code:-26" Can't figure out where it's coming from. |
I updated this from feedback on discord that maxFeeRate was a float, but I'm pretty sure it's supposed to be an int. When I change from Also need to investigate |
@coolaj86 so we need one more PR? |
All related PRs have been opened. I've tested locally going over and under the maximum fee. |
Feedback wanted: What should the default
maxFeeRate
be?Re: dashpay/insight-ui#75