Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy payout #346

Merged
merged 18 commits into from
Mar 17, 2020
Merged

Lazy payout #346

merged 18 commits into from
Mar 17, 2020

Conversation

AurevoirXavier
Copy link
Member

No description provided.

@AurevoirXavier
Copy link
Member Author

@clearloop Could you fix the tests? Base on 75116bd8c45c7e46a9b8eed9cb29ee4256ed631b.

@AurevoirXavier AurevoirXavier mentioned this pull request Mar 14, 2020
Closed
@clearloop
Copy link
Contributor

clearloop commented Mar 14, 2020 •
edited
Loading

@AurevoirXavier Ok...

@AurevoirXavier AurevoirXavier linked an issue Mar 14, 2020 that may be closed by this pull request
Staking module currently are using for loop to pay dividends. #55
Closed
@hackfisher
Copy link
Contributor

hackfisher commented Mar 14, 2020 •
edited
Loading

@clearloop Could you fix the tests? Base on 75116bd8c45c7e46a9b8eed9cb29ee4256ed631b.

@AurevoirXavier @clearloop
Github seems to support collaborating with others by committing to a pull request, might need some permission config from PR's owner.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

BTW, the CI build failed.

@clearloop
Copy link
Contributor

Github seems to support commit to a pull request, might need some permission config from PR's owner.

Ok, I'll fork @AurevoirXavier 's branch

@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Mar 14, 2020 •
edited
Loading

@AurevoirXavier @clearloop
Github seems to support collaborating with others by committing to a pull request, might need some permission config from PR's owner.

help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork

Example: #170

BTW, the CI build failed.

#347 (comment)

@clearloop
Copy link
Contributor

clearloop commented Mar 14, 2020 •
edited
Loading

Example: #170

Steps

  • fix substrate_tests
  • patch docs
  • fix darwinia_tests
  • fix reward
  • patch docs

@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Mar 16, 2020 •
edited
Loading

I'll finish the rest of the tests.

Move to #351, due to some questions.

@hackfisher hackfisher merged commit e164cf0 into darwinia-network:develop Mar 17, 2020
@AurevoirXavier AurevoirXavier deleted the lazy-payout branch March 17, 2020 08:32
@clearloop clearloop mentioned this pull request Mar 17, 2020
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Mar 20, 2020
Merged
boundless-forest added a commit that referenced this pull request Aug 1, 2023
@boundless-forest
Tx gas should never larger than block limit (#346)
63c4a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clearloop clearloop clearloop left review comments

@hackfisher hackfisher hackfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Staking module currently are using for loop to pay dividends.
3 participants
@AurevoirXavier @clearloop @hackfisher