Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Some Modules in Next Substrate Release #347

Closed
AurevoirXavier opened this issue Mar 14, 2020 · 2 comments · Fixed by #356
Closed

Remove Some Modules in Next Substrate Release #347

AurevoirXavier opened this issue Mar 14, 2020 · 2 comments · Fixed by #356
Assignees
@AurevoirXavier
Milestone
Darwinia Crab Net...

Comments

@AurevoirXavier
Copy link
Member

To keep the same deps version, I've to modify the session module in #346.
@AurevoirXavier AurevoirXavier self-assigned this Mar 14, 2020
@hackfisher hackfisher added this to the Darwinia Crab Network milestone Mar 14, 2020
@AurevoirXavier AurevoirXavier changed the title Remove the Session Module in Next Substrate Release Remove Some Modules in Next Substrate Release Mar 14, 2020
@AurevoirXavier
Copy link
Member Author

AurevoirXavier commented Mar 14, 2020 •
edited
Loading

To keep all deps using the same version of session, I modified these module:

  • frame/authority-discovery
  • frame/babe
  • frame/grandpa
  • frame/im-online
  • frame/offences
  • frame/session
  • primitives/staking

@AurevoirXavier AurevoirXavier mentioned this issue Mar 14, 2020
Merged
hackfisher pushed a commit that referenced this issue Mar 17, 2020
@AurevoirXavier
Lazy payout (#346)
e164cf0 
* fix: avoid using substrate native name

* update: adjust RING/DOT ratio

* update: better error info

* update: sign prefix

* update: accuracy

* update: claims list

* remove: migration tests

* add: session

* fix: tests

* fix: RING/DOT ratio

* add: session

* update: lazy payout

* update: deps

* todo: tests

* update: resolve deps, #347

* update: deps

* update: set default history depth to 14 days
@hackfisher
Copy link
Contributor

#356

@AurevoirXavier AurevoirXavier linked a pull request Mar 18, 2020 that will close this issue
Substrate Upgrade #356
Merged
AurevoirXavier added a commit that referenced this issue Mar 21, 2020
@AurevoirXavier @clearloop
Staking Substrate Tests (#351)
6f08993 
* fix: avoid using substrate native name

* update: adjust RING/DOT ratio

* update: better error info

* update: sign prefix

* update: accuracy

* update: claims list

* remove: migration tests

* add: session

* fix: tests

* fix: RING/DOT ratio

* add: session

* update: lazy payout

* update: deps

* todo: tests

* update: resolve deps, #347

* update: deps

* fix: substrate_tests in staking pallet

* patch: docs for staking tests

* fix: darwinia_tests in staking pallet

* fix: patch docs for staking

* update: mock

* update: tests

* add: substrate tests

* fix: `basic_setup_works`

* fix: `change_controller_works`

* fix: #340

* fix: `rewards_should_work`

* fix: `staking_should_work`

* update: move error types to mock

* update: format

* fix: `nominating_and_rewards_should_work`

* fix: `nominators_also_get_slashed`

* update: format

* fix: `cannot_transfer_staked_balance`

* fix: `cannot_transfer_staked_balance_2`

* update: format

* update: chain spec

* fix: `reward_destination_works`

* update: `<Module<Test>>` to `Staking`

* fix: `validator_payment_prefs_work`

* fix: #362, #363

* fix: `bond_extra_works`

* update: mark `bond_extra_and_withdraw_unbonded_works` as deprecated

* update: simple error type

* add: east-testing feature

* fix: #365

* fix: `bond_with_no_staked_value`

* fix: `too_many_unbond_calls_should_not_work`

* fix: `reward_to_stake_works`

* update: use `Default::default()` to avoid unused code

* fix: `on_free_balance_zero_stash_removes_validator`

* fix: `on_free_balance_zero_stash_removes_nominator`

* fix: `switching_roles`

* fix: `bond_with_little_staked_value_bounded_by_slot_stake`

* fix: `phragmen_should_not_overflow_nominators`

* fix: `phragmen_should_not_overflow`

* fix: `reward_validator_slashing_validator_doesnt_overflow`

* add: `unbonded_balance_is_not_slashable`

* update: `offence_forces_new_era`, `offence_ensures_new_era_without_clobbering`

* fix: `offence_deselects_validator_when_slash_is_zero`

* fix: `slashing_performed_according_exposure`

* fix: `slash_in_old_span_does_not_deselect`

* remove: `ensure_storage_upgraded`

* fix: #373

* fix: #374, #375

* fix: `subsequent_reports_in_same_span_pay_out_less`

* add: `invulnerables_are_not_slashed`

* fix: use `free_balance`

* update: use `free_balance`

* fix: `remove_multi_deferred`

* add: `claim_reward_at_the_last_era_and_no_double_claim_and_invalid_claim`

* add: `six_session_delay`

* add: `test_max_nominator_rewarded_per_validator_and_cant_steal_someone_else_reward`

* add: `set_history_depth_works`

* add: `slashing_nominators_by_span_max`

* add: `slashes_are_summed_across_spans`

* fix: squash problem

* update: chain spec

* fix: merge problem

Co-authored-by: clearloop <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AurevoirXavier AurevoirXavier

Labels
None yet
Projects
None yet
Milestone
Darwinia Crab Network
Development

Successfully merging a pull request may close this issue.

Substrate Upgrade
2 participants
@hackfisher @AurevoirXavier