Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix htmlinputstream, tokenizer to use codepoints and build strings as late as possible #1113

Closed
DartBot opened this issue Jun 4, 2015 · 5 comments
Labels
closed-duplicate Closed in favor of an existing report package:html type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="96" height="96"hspace="10"> Issue by sethladd
Originally opened as dart-lang/sdk#16704


There's a todo explaining, but I think we can radically simplify this class and base it on codepoints instead of building up string chunks. I'd also like to remove the RegExp that is used for "charsUntil"

This could be done in two phases also, first simplify inputstream then tokenizer

@DartBot DartBot added the type-enhancement A request for a change that isn't a bug label Jun 4, 2015
@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Added Pkg-Html5Lib label.

@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

<img src="https://avatars.githubusercontent.com/u/17034?v=3" align="left" width="48" height="48"hspace="10"> Comment by kevmoo


Removed Library-Html5lib label.

@jmesserly
Copy link

funny to see bugs bouncing around :) ... this was originally filed by me, but I don't think it's super high pri anymore. The only perf issue we've seen is the string concat, which is (more or less) fixed now.

@jmesserly
Copy link

also is covered by #1094 :)

@jmesserly jmesserly added the closed-duplicate Closed in favor of an existing report label Jul 6, 2015
@mosuem mosuem transferred this issue from dart-archive/html Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report package:html type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants