Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use char codes instead of strings #1094

Open
jmesserly opened this issue Mar 5, 2015 · 0 comments
Open

cleanup: use char codes instead of strings #1094

jmesserly opened this issue Mar 5, 2015 · 0 comments

Comments

@jmesserly
Copy link

related to #1093, there's a lot of too-eager char codes -> string conversions, and a lot of 1 character strings. It'd be nice to have inputstream.dart return int and List<int> and have tokenizer.dart consume those, not stringifying until ready to send tokens to the parser. Also, for character/space tokens it would be nice to preserve it even longer, and fix the treebuilder insertText code path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants