Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix htmlinputstream, tokenizer to use codepoints and build strings as late as possible #16704

Closed
sethladd opened this issue Feb 10, 2014 · 4 comments
Closed

fix htmlinputstream, tokenizer to use codepoints and build strings as late as possible #16704

sethladd opened this issue Feb 10, 2014 · 4 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@sethladd
Copy link
Contributor

There's a todo explaining, but I think we can radically simplify this class and base it on codepoints instead of building up string chunks. I'd also like to remove the RegExp that is used for "charsUntil"

This could be done in two phases also, first simplify inputstream then tokenizer
@sethladd
Copy link
Contributor Author

Was https://github.com/dart-lang/html5lib-now-on-dart.googlecode.com/issues/23

@kevmoo
Copy link
Member

kevmoo commented Feb 13, 2014

Added Pkg-Html5Lib label.

@kevmoo
Copy link
Member

kevmoo commented Feb 13, 2014

Removed Library-Html5lib label.

@sethladd sethladd added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Feb 13, 2014
@DartBot DartBot mentioned this issue Jun 4, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 4, 2015

This issue has been moved to dart-lang/tools#1113.

@DartBot DartBot closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sethladd @kevmoo @DartBot