Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☂️ Digit separators #56188

Closed
16 tasks done
srawlins opened this issue Jul 9, 2024 · 1 comment
Closed
16 tasks done

☂️ Digit separators #56188

srawlins opened this issue Jul 9, 2024 · 1 comment
Assignees
@srawlins
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@srawlins
Copy link
Member

srawlins commented Jul 9, 2024 •
edited
Loading

We're adding support for digit separators in number literals. For example:

100__000_000__000_000__000_000  // one hundred million million millions!
0x4000_0000_0000_0000
0.000_000_000_01
0x00_14_22_01_23_45  // MAC address
555_123_4567  // US Phone number

See the feature specification for full details.
@srawlins srawlins added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug labels Jul 9, 2024
@srawlins srawlins self-assigned this Jul 9, 2024
copybara-service bot pushed a commit that referenced this issue Jul 15, 2024
@srawlins
Prepare prefer_int_literals rule and fix for digit separators
63f47bb 
Work towards #56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I3a6ed7cb8b61a63c0b2742f408e42e4ae09d732a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375741
Commit-Queue: Samuel Rawlins <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 15, 2024
@srawlins
analyzer: Support digit separators in use_full_hex rule
d84619e 
Work towards #56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I75897ffdcacd3613b9e5f5095932f514c4653fac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/375780
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
copybara-service bot pushed a commit that referenced this issue Jul 29, 2024
@srawlins
analyzer: Test digit separators feature with some integer_literals er…
6c746eb 
…rors

Work towards #56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I61aeef91c47e9671998668ad857cc2add1f692e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377861
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
@mit-mit mit-mit mentioned this issue May 22, 2024
Closed
@srawlins srawlins mentioned this issue Aug 14, 2024
Closed
copybara-service bot pushed a commit that referenced this issue Aug 14, 2024
@srawlins
DAS: add some tests for digit separators in DocumentColor feature
9d61a35 
Work towards #56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: Id3d56ad5870208e15e89ad014a668a1e659b7d75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380621
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
copybara-service bot pushed a commit that referenced this issue Aug 15, 2024
@srawlins
DAS: Add digit separator tests for highlighting
f60b5bd 
Work towards #56188

Cq-Include-Trybots: luci.dart.try:flutter-analyze-try,analyzer-win-release-try,pkg-win-release-try
Change-Id: I852c9fe2301c297b8e5ae5b3157153774eaca740
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380640
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Samuel Rawlins <[email protected]>
@srawlins
Copy link
Member Author

Done.

@sgrekhov sgrekhov mentioned this issue Oct 1, 2024
Closed
@parlough parlough mentioned this issue Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srawlins