Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Digit separators] Syntax highlighters implementation #56187

Closed
4 of 5 tasks
Tracked by #56188
srawlins opened this issue Jul 9, 2024 · 4 comments
Closed
4 of 5 tasks
Tracked by #56188

[Digit separators] Syntax highlighters implementation #56187

srawlins opened this issue Jul 9, 2024 · 4 comments
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@srawlins srawlins added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). labels Jul 9, 2024
@srawlins srawlins mentioned this issue Jul 9, 2024
16 tasks
@srawlins
Copy link
Member Author

I think we should skip CodeMirror (and can skip it for language features going forward).

AFAICT there is only existing Dart support for CodeMirror 5. For CodeMirror 6 there is a new way to specify a language mode, a new way to specify the parser, and there is no support for Dart as a language in CodeMirror 6. It would be great to add that support, but as for the Digit separators feature, I think it is not important to bump the support for CodeMirror 5, and a separate effort to wire up CodeMirror 6.

@bwilkerson
Copy link
Member

@anderdobo @mossmana

@srawlins
Copy link
Member Author

srawlins commented Sep 5, 2024

I added back CodeMirror 5 since DartPad actually still runs on CodeMirror 5.

@srawlins
Copy link
Member Author

Calling this done. google3 can be tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants