Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Dropping NodeAttrs from the injectable services #768

Closed
wants to merge 7 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 19, 2014

This is PR is currently in an early stage and will be subject to change.

Edit 0401:

TODO:

  • Some pending issues with ng-attr-*
  • Some pending issues with ng-class
  • Finalize the removal of the NodeAttrs usages

@vicb vicb added cla: yes and removed cla: no labels Mar 19, 2014
@mhevery
Copy link
Contributor

mhevery commented Apr 1, 2014

These look good to me. Is this ready to go in? The title says WIP

@vicb
Copy link
Contributor Author

vicb commented Apr 1, 2014

Still some work to do on this one - I'll update the title and ping you when it's ready

@vicb vicb changed the title [WIP] Dropping NodeAttrs from the injectable services Dropping NodeAttrs from the injectable services Apr 3, 2014
@vicb
Copy link
Contributor Author

vicb commented Apr 3, 2014

@mhevery If Travis agrees, i think this can be merged. There are still some NodeAttrs usage left but I need more thinking to come to a clean solution.

@vicb
Copy link
Contributor Author

vicb commented Apr 4, 2014

Seems like this has been merged on 0404.

@vicb vicb closed this Apr 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

change ng-repeat/ng-class/ng-style to use new change record in change detection
2 participants