Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

change ng-repeat/ng-class/ng-style to use new change record in change detection #645

Closed
mhevery opened this issue Feb 27, 2014 · 3 comments
Closed

change ng-repeat/ng-class/ng-style to use new change record in change detection #645

mhevery opened this issue Feb 27, 2014 · 3 comments
Milestone
0.9.11

Comments

@mhevery
Copy link
Contributor

mhevery commented Feb 27, 2014

This directives work on collections / maps, and should therefore take advantage of the ChangeRecord which is computed by the new change detection.
@mhevery mhevery added this to the v1.0 milestone Feb 27, 2014
@vicb vicb self-assigned this Mar 3, 2014
@vicb vicb modified the milestones: v0.9.9, v1.0 Mar 3, 2014
@vicb vicb removed their assignment Mar 3, 2014
@matsko matsko modified the milestones: 0.9.10, v0.9.9 Mar 10, 2014
@vicb vicb mentioned this issue Mar 14, 2014
Closed
@jbdeboer
Copy link
Contributor

Assigned to @vicb

@vicb
Copy link
Contributor

vicb commented Mar 19, 2014

ng-style is ok.
ng-repeat is handled in #751.

vicb added a commit to vicb/angular.dart that referenced this issue Mar 20, 2014
@vicb
feat(ngRepeat): make use if the new change detection
e91dc8b 
closes dart-archive#728
relates to dart-archive#645
@vicb vicb modified the milestones: 0.11.0, 0.10.0 Mar 20, 2014
vicb added a commit to vicb/angular.dart that referenced this issue Mar 21, 2014
@vicb
feat(ngRepeat): make use if the new change detection
1291fd4 
closes dart-archive#728
relates to dart-archive#645
vicb added a commit to vicb/angular.dart that referenced this issue Mar 21, 2014
@vicb
feat(ngRepeat): make use if the new change detection
196d189 
closes dart-archive#728
relates to dart-archive#645
vicb added a commit that referenced this issue Mar 25, 2014
@vicb @mhevery
feat(ngRepeat): make use if the new change detection
09871cb 
closes #728
relates to #645
vicb added a commit to vicb/angular.dart that referenced this issue Apr 1, 2014
@vicb
ONGOING refactor(ngclass): drop NodeAttrs, use new change detection
3d6fee2 
Relates to dart-archive#645
@vicb vicb mentioned this issue Apr 1, 2014
Closed
@vicb
Copy link
Contributor

vicb commented Apr 8, 2014

The PR has been merged on 0404

@vicb vicb closed this as completed Apr 8, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
0.9.11
Development

Successfully merging a pull request may close this issue.

Dropping NodeAttrs from the injectable services vicb/angular.dart
4 participants
@matsko @mhevery @vicb @jbdeboer