Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/improvements #69

Merged
merged 1 commit into from
May 2, 2021
Merged

Fixes/improvements #69

merged 1 commit into from
May 2, 2021

Conversation

nlemoine
Copy link
Contributor

  • Remove composer dev dependencies
  • Only load local dependencies (dist/autoload.php) if dependencies are not already loaded (Bedrock or similar)
  • Remove composer.lock
  • Update build process
  • Fix coding standards
  • Fix undefined variable in sober/intervention/return filter
  • Fix docs typos

@nlemoine
Copy link
Contributor Author

Hi @darrenjacoby,

Following on #68, I decided to give this PR a try. Let me know if you need more details on some changes I made.

@darrenjacoby
Copy link
Owner

@nlemoine this is looking great! thank you so much! I'll test and then merge.

@nlemoine
Copy link
Contributor Author

Thanks! I'll have some more PR coming :)

- Only load local dependencies (dist/autoload.php) if dependencies are not already loaded (Bedrock or similar)
- Remove composer.lock
- Update build process
- Fix coding standards
- Fix undefined variable in `sober/intervention/return` filter
- Fix docs typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants